Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] move explicitly to use ubuntu 24.04 runners #11816

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Dec 6, 2024

Description

Rather than use ubuntu-latest, which will move over a period of time to ubuntu 24.04, directly move to ubuntu 24.04 to avoid having flaky or unexpected failures.

See actions/runner-images#10636 for context.

@atoulme atoulme requested a review from a team as a code owner December 6, 2024 19:00
@atoulme atoulme requested a review from jpkrohling December 6, 2024 19:00
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.54%. Comparing base (71f7d9e) to head (c8b4dbb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11816   +/-   ##
=======================================
  Coverage   91.54%   91.54%           
=======================================
  Files         445      445           
  Lines       23733    23733           
=======================================
  Hits        21727    21727           
  Misses       1629     1629           
  Partials      377      377           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If tests are passing with ubuntu-latest and ubuntu-24.04, is there a reason for changing this? i'd expect this to be more needed if we saw failures that we would need to address, but maybe i'm missing something

@atoulme
Copy link
Contributor Author

atoulme commented Dec 6, 2024

No, you understood right. We can let go and keep using ubuntu-latest as this proves we should be ok either way. I was just making sure we would be ok.

@dmathieu
Copy link
Member

dmathieu commented Dec 7, 2024

If failures were expected (which doesn't seem to be the case), should we run on both 22.04 and 24.04 (and possibly even 20.04 until it's EOL next april)?
Folks will probably keep running their collector on those versions for some time.

@jpkrohling
Copy link
Member

should we run on both 22.04 and 24.04

I don't think it brings much value, and would increase our CI time significantly.

@andrzej-stencel
Copy link
Member

andrzej-stencel commented Dec 9, 2024

If tests are passing with ubuntu-latest and ubuntu-24.04, is there a reason for changing this? i'd expect this to be more needed if we saw failures that we would need to address, but maybe i'm missing something

No, you understood right. We can let go and keep using ubuntu-latest as this proves we should be ok either way. I was just making sure we would be ok.

I like the Ubuntu version being stated explicitly, but It's probably not a big deal, can have it either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants